Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: use separate report interval for hot peer stat #3661

Merged
merged 11 commits into from
May 11, 2021
Merged

statistics: use separate report interval for hot peer stat #3661

merged 11 commits into from
May 11, 2021

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented May 10, 2021 •
edited
Loading

What problem does this PR solve?

Use separate report interval for hot peer stat

What is changed and how it works?

Use separate report interval for hot peer stat

Check List

Tests

  • Unit test

Release note

  • No release note

@ti-chi-bot ti-chi-bot requested review from lhy1024 and rleungx May 10, 2021 06:17
@Yisaer Yisaer force-pushed the schedule_by_peer branch from 3bb96c2 to 7d82d39 Compare May 10, 2021 06:20
@Yisaer
separte interval
3636d1a 
Signed-off-by: yisaer <[email protected]>
@Yisaer Yisaer force-pushed the schedule_by_peer branch from b7039c6 to 3636d1a Compare May 10, 2021 07:30
Yisaer added 2 commits May 10, 2021 15:36
@Yisaer
fix lint
f651423 
Signed-off-by: yisaer <[email protected]>
@Yisaer
fix test
9ea78b2 
Signed-off-by: yisaer <[email protected]>
@codecov
Copy link

codecov bot commented May 10, 2021 •
edited
Loading

Codecov Report

Merging #3661 (b355b58) into master (5156501) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3661      +/-   ##
==========================================
+ Coverage   74.67%   74.71%   +0.03%     
==========================================
  Files         245      245              
  Lines       24240    24247       +7     
==========================================
+ Hits        18102    18116      +14     
+ Misses       4524     4516       -8     
- Partials     1614     1615       +1
Flag Coverage Δ
unittests 74.71% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/statistics/hot_peer.go 100.00% <100.00%> (ø)
server/statistics/hot_peer_cache.go 94.57% <100.00%> (+0.10%) ⬆️
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/member/member.go 65.59% <0.00%> (-2.69%) ⬇️
client/base_client.go 82.98% <0.00%> (-1.55%) ⬇️
server/core/storage.go 67.68% <0.00%> (-0.77%) ⬇️
server/tso/allocator_manager.go 74.87% <0.00%> (-0.33%) ⬇️
server/grpc_service.go 47.85% <0.00%> (-0.23%) ⬇️
client/client.go 71.82% <0.00%> (-0.14%) ⬇️
server/cluster/cluster.go 83.25% <0.00%> (-0.13%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5156501...b355b58. Read the comment docs.

rleungx
rleungx reviewed May 10, 2021
View reviewed changes
server/schedulers/hot_test.go Outdated Show resolved Hide resolved
server/schedulers/hot_test.go Show resolved Hide resolved
Yisaer added 4 commits May 10, 2021 16:57
@Yisaer
address the comment
0082ffc 
Signed-off-by: yisaer <[email protected]>
@Yisaer
fix test
3d8fd77 
Signed-off-by: yisaer <[email protected]>
@Yisaer
remove useless code
002215f 
Signed-off-by: yisaer <[email protected]>
@Yisaer
remove useless code
494a801 
Signed-off-by: yisaer <[email protected]>
@Yisaer Yisaer force-pushed the schedule_by_peer branch from d8519d5 to 494a801 Compare May 10, 2021 12:09
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 10, 2021
lhy1024
lhy1024 reviewed May 10, 2021
View reviewed changes
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest LGTM

server/statistics/hot_peer.go Outdated Show resolved Hide resolved
tests/pdctl/hot/hot_test.go Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 11, 2021
@Yisaer
Copy link
Contributor Author

Yisaer commented May 11, 2021

/merge

@ti-chi-bot
Copy link
Member

@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ad07e97

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 11, 2021
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Yisaer
Copy link
Contributor Author

Yisaer commented May 11, 2021

/merge

@ti-chi-bot
Copy link
Member

@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 8e3564d into tikv:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yisaer @ti-chi-bot @lhy1024 @rleungx